First column width of album details page issue

0
Hi Germi,

The column width of the album details page cannot be less than 412px if you have bookmarks turned on. It is hard-coded in bookmarks.php. If I want something less than 412px, I would have to modify the core music collection code, and would rather not do that.

You already have CSS code (.first_col) where width can be set.

I took the width and height ($width_fb and $height_fb in MusColBookmarks::show_bookmarks) out of the iframe return (see attached graphic) and it all works fine. The bookmarks display width are now controlled by CSS (.first_col in album.css).

Could this hard-coded section in bookmarks.php be removed in the next release?

http://www.joomlamusicsolutions.com/images/fbfiles/images/graphic.png
Attachments:
Responses (5)
  • Accepted Answer

    Thursday, December 06 2012, 10:48 PM - #Permalink
    0
    Also, other question... I see two post variable 'showtwitter' and 'showfacebook' being referenced in show_bookmarks(), but could not find them in the bookmarks configuration screen in the back end. Where can I set them? I'd like to turn off twitter but leave facebook on.
    The reply is currently minimized Show
  • Accepted Answer

    Friday, December 07 2012, 05:13 PM - #Permalink
    0
    they are in "global" tab :)
    The reply is currently minimized Show
  • Accepted Answer

    Friday, December 07 2012, 05:23 PM - #Permalink
    0
    germi wrote:
    they are in "global" tab :)

    wow... can't believe how many times I looked at that configuration page and just never saw them. Thanks! Please let me know what you think about removing the width/height variables for the facebook iframe when you get a chance.
    The reply is currently minimized Show
  • Accepted Answer

    Friday, December 07 2012, 05:30 PM - #Permalink
    0
    yes I'll include this in next release probably :)
    The reply is currently minimized Show
  • Accepted Answer

    Friday, December 07 2012, 06:09 PM - #Permalink
    0
    Thanks, that would be great!
    The reply is currently minimized Show
Your Reply